-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: onboarding API via proxy #6058
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 3171894 in 17 seconds
More details
- Looked at
38
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. ee/query-service/integrations/gateway/proxy.go:13
- Draft comment:
Update the comment or documentation to reflect thatAllowedPrefix
is now a slice of strings, not a single string. - Reason this comment was not posted:
Confidence changes required:50%
The change from a single string to a slice for AllowedPrefix is not reflected in the comment or documentation, which could lead to confusion.
2. ee/query-service/integrations/gateway/proxy.go:13
- Draft comment:
Avoid using thecomponent/index.tsx
file structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_jsnNKFqNQP2WjeyB
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on eb99755 in 20 seconds
More details
- Looked at
13
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. ee/query-service/integrations/gateway/proxy.go:13
- Draft comment:
The PR description mentions adding "/v1/onboardingAnswers" to the allowed prefixes, but this change is not reflected here. Please ensure that "/v1/onboardingAnswers" is added to theAllowedPrefix
list. - Reason this comment was not posted:
Comment did not seem useful.
2. ee/query-service/integrations/gateway/proxy.go:10
- Draft comment:
Avoid using thecomponent/index.tsx
file structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. This applies to theproxy.go
file. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_aPGRgWE7p39VeosZ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Summary
Added "/v1/onboardingAnswers" API via proxy
Important
Add
/v1/onboardingAnswers
API endpoint to proxy by updating allowed prefixes ingateway.go
andproxy.go
./v1/onboardingAnswers
to allowed prefixes inproxy.go
.ServeGatewayHTTP
ingateway.go
to handle multiple allowed prefixes.AllowedPrefix
fromstring
to[]string
inproxy.go
.AllowedPrefix
inServeGatewayHTTP
to validate paths.This description was created by for eb99755. It will automatically update as commits are pushed.