Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onboarding API via proxy #6058

Merged
merged 4 commits into from
Oct 17, 2024
Merged

feat: onboarding API via proxy #6058

merged 4 commits into from
Oct 17, 2024

Conversation

makeavish
Copy link
Member

@makeavish makeavish commented Sep 24, 2024

Summary

Added "/v1/onboardingAnswers" API via proxy


Important

Add /v1/onboardingAnswers API endpoint to proxy by updating allowed prefixes in gateway.go and proxy.go.

  • API Changes:
    • Add /v1/onboardingAnswers to allowed prefixes in proxy.go.
    • Update ServeGatewayHTTP in gateway.go to handle multiple allowed prefixes.
  • Code Structure:
    • Change AllowedPrefix from string to []string in proxy.go.
    • Iterate over AllowedPrefix in ServeGatewayHTTP to validate paths.

This description was created by Ellipsis for eb99755. It will automatically update as commits are pushed.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the enhancement New feature or request label Sep 24, 2024
@makeavish makeavish marked this pull request as ready for review October 8, 2024 17:00
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 3171894 in 17 seconds

More details
  • Looked at 38 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. ee/query-service/integrations/gateway/proxy.go:13
  • Draft comment:
    Update the comment or documentation to reflect that AllowedPrefix is now a slice of strings, not a single string.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change from a single string to a slice for AllowedPrefix is not reflected in the comment or documentation, which could lead to confusion.
2. ee/query-service/integrations/gateway/proxy.go:13
  • Draft comment:
    Avoid using the component/index.tsx file structure approach, as it makes it difficult to debug and find components using global search tools like VS Code.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_jsnNKFqNQP2WjeyB


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

github-actions bot commented Oct 8, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link

github-actions bot commented Oct 8, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on eb99755 in 20 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. ee/query-service/integrations/gateway/proxy.go:13
  • Draft comment:
    The PR description mentions adding "/v1/onboardingAnswers" to the allowed prefixes, but this change is not reflected here. Please ensure that "/v1/onboardingAnswers" is added to the AllowedPrefix list.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. ee/query-service/integrations/gateway/proxy.go:10
  • Draft comment:
    Avoid using the component/index.tsx file structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. This applies to the proxy.go file.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_aPGRgWE7p39VeosZ


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@makeavish makeavish merged commit 337a941 into develop Oct 17, 2024
12 of 14 checks passed
@makeavish makeavish deleted the feat/onboarding-api branch October 17, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants