fix: added time range key for query and local storage handling #6009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
YounixM
previously approved these changes
Sep 18, 2024
SagarRajput-7
previously approved these changes
Sep 18, 2024
YounixM
previously approved these changes
Sep 18, 2024
|
In the result query, I could see two kinds of issues: 1. the list of values selected for the variable is different, and 2. the value for multi-select is sent as a single string instead of a list of strings with one item. Does this change fix both of them? |
vikrantgupta25
dismissed stale reviews from YounixM and SagarRajput-7
via
14533cc
yes both of them have been fixed. let me know when you have tested the same. thank you 🙌 |
|
LGTM. Things tested
|
YounixM
approved these changes
Sep 19, 2024
srikanthccv
pushed a commit
that referenced
this pull request
Sep 19, 2024
* fix: added time range key for query and local storage handling * chore: fix jest test cases * fix: send single element array for only variable option as well * fix: intermediate stale data should not be shown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ALLthe local storage values needs to be updated.Related Issues / PR's
Screenshots
NA
Affected Areas and Manually Tested Areas