Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add support for caching multiple time ranges for cache key #6008

Merged
merged 7 commits into from
Sep 20, 2024
Merged

chore: add support for caching multiple time ranges for cache key #6008

merged 7 commits into from
Sep 20, 2024

Conversation

srikanthccv
Copy link
Member

Summary

Fixes #6002

@github-actions github-actions bot added the chore label Sep 18, 2024
@srikanthccv srikanthccv marked this pull request as ready for review September 20, 2024 04:45
nityanandagohain
nityanandagohain approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@nityanandagohain nityanandagohain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though do some sanity testing on actual prod data.

@srikanthccv srikanthccv merged commit 033b64a into develop Sep 20, 2024
13 checks passed
@srikanthccv srikanthccv deleted the improve-qc branch September 20, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nityanandagohain nityanandagohain nityanandagohain approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support caching multiple time ranges for same cache key
2 participants
@srikanthccv @nityanandagohain