Fix: cheaper query for fetching log attribute values for filter suggestions #5989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nityanandagohain
approved these changes
Sep 17, 2024
raj-k-singh
deleted the
fix/cheaper-query-for-fetching-attribs-for-log-attribute
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The existing query worked fine for most attributes that typically do not have a large number of distinct values.
However, while uncommon, attributes like
messagecan end up having 100s of millions of values in the tag_attributes table.This change updates the query used for fetching log attribute values to ensure it is always cheap regardless of how many values an attribute has in the tag_attributes table.
Related Issues / PR's
Fixes #5988
Affected Areas and Manually Tested Areas
Logs filter suggestions