fix: check alert rule queries are all disabled if at least one query is set #5966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srikanthccv
reviewed
Sep 18, 2024
…b.com:kobecal/signoz into fix/panic_on_rule_if_all_queries_are_disabled
…b.com:kobecal/signoz into fix/panic_on_rule_if_all_queries_are_disabled
srikanthccv
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A alert rule is created and it's all queries are disabled. Then alert manager will get panic because of no matched query result to trigger alert.
Related Issues / PR's
#5964
Screenshots
NA
Affected Areas and Manually Tested Areas
create, update alert rule