fix: dont request query progress reporting if reporting query start failed #5958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
…t-report-succeeds
srikanthccv
approved these changes
Sep 17, 2024
raj-k-singh
deleted the
fix/qb-only-report-progress-if-query-start-report-succeeds
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change ensures query progress reporting for clickhouse queries is only requested if reporting the start of query succeeds.
Otherwise progress reports are made for queries that failed to registered with the progress tracker.
Failing to register query start should usually never happen, but we have encountered a case with query id collision that prevented reporting of start of a query
Related Issues / PR's
Contributes to https://github.com/SigNoz/engineering-pod/issues/1782
Affected Areas and Manually Tested Areas
Logs Query progress