Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added view logs button for error and latency chart #5826

Merged
merged 13 commits into from
Oct 4, 2024

Conversation

rahulkeswani101
Copy link
Contributor

Summary

Related Issues / PR's

#5729

Screenshots

image

image

image

image

Affected Areas and Manually Tested Areas

@github-actions github-actions bot added the enhancement New feature or request label Sep 2, 2024
@rahulkeswani101
Copy link
Contributor Author

https://www.loom.com/share/92c3b9ec05cd4340a20de8e4241b9a41?sid=ad6e2a10-3d60-49ba-8049-0f3c86d961b5

@ankitnayan Fixed the issues mentioned in the recording except for the spinner issue.

@ankitnayan
Copy link
Collaborator

ankitnayan commented Sep 8, 2024

https://www.loom.com/share/e8704d815b914566a2307057fa77cc97?sid=70c688a1-cad7-431a-b3a8-23645b9bf0e0

  1. Incorrect end timestamp passed from error panel
  2. Resource attributes like environment and host.name not passed to logs
  3. Change severity_text=ERROR to severity_text IN (ERROR, FATAL). @nityanandagohain is this search case sensitive at backend and should we rather use severity_number>X?

@nityanandagohain
Copy link
Member

For attributes, it's case-sensitive.

severity_number has another issue, it is not present in the order_by clause.

@ankitnayan
Copy link
Collaborator

For attributes, it's case-sensitive.

severity_number has another issue, it is not present in the order_by clause.

It should be there, right? Please create an issue and we shall fix this later

@ankitnayan
Copy link
Collaborator

#5827

SagarRajput-7
SagarRajput-7 previously approved these changes Sep 26, 2024
ahmadshaheer
ahmadshaheer previously approved these changes Sep 26, 2024
Copy link
Collaborator

@ahmadshaheer ahmadshaheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes, @rahulkeswani101.

Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahulkeswani101 rahulkeswani101 self-assigned this Oct 4, 2024
@rahulkeswani101 rahulkeswani101 merged commit 69aab87 into develop Oct 4, 2024
12 of 13 checks passed
@rahulkeswani101 rahulkeswani101 deleted the SIG-5729 branch October 4, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants