feat(paywall blocker): improvements for trial end blocker screen #5756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the dropdown overlay width to 200px to provide breathing space for the dropdown button. Added flex to wrap the dropdown button to create space between the right icon and the left elements.
- added new components locally for rendering static contents - fixed SCSS code for better readablity - seperated data to specific file - added alert info style for the non admin users message
|
|
@sharpshooter90 : How would it look along with the banner we show on top when the trail is about to expire? |
YounixM
reviewed
Aug 23, 2024
YounixM
reviewed
Aug 23, 2024
YounixM
reviewed
Aug 23, 2024
|
@sharpshooter90 I see this is still in draft stage? |
|
|
sharing the latest screen updates as a video here: https://www.loom.com/share/2dfe83b5b3834ea9aa9733ec2143165b?sid=888c5a64-1bd8-4e33-88b2-93e025b4c300 |
|
@YounixM I need help to fixing the build issues, tried it the local build but not able to see the errors. |
added English and English-GB translations for workspace locked messages
|
@YounixM The blocker for me is WorkspaceLocked.test.tsx.
|
- I have removed the scope for unitest having locale support - remove the useEffect way to set sidebar collapse, instead added it in app layout - removed the opacity effect on tabs
|
@vikrantgupta25 I have removed the translation from the text inside the unit test. We can scope these changes related to the unit test in another PR. Thank you for the pair review session. 
|
sharpshooter90
commented
Sep 2, 2024
…he isWorkspaceLocked function
…t to a constant expression
vikrantgupta25
previously approved these changes
Sep 5, 2024
YounixM
approved these changes
Sep 6, 2024
YounixM
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues / PR's
https://github.com/SigNoz/growth-pod/issues/486
Screenshots