-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: consume the new search bar #5728
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add test cases to alteast start in that direction, else it will be treated as a secondary citizen and these manual testing will get monotonous.
Checks
- static field data type is not shown eg:- severity_text, severity_number
- Not able to update the value of operator after running a query ( replaces with old value) ( change the value wait for the suggestion to update then it works but rapid typing doesn't)
- Contains and other filters working properly
- Filtering from the detail page by clicking on attribute name not working
- Filter in , filter out from detail page doesn't update the search bar. (refreshing the window makes them appear)
- There is a flicker after selecting a key value pair.
- The filter doesn't get cleared if I got to some other page like alerts and come back
Questions ?
- if attr named
x
is of both float and string, then if I type x then is string type selected by default ( that what it seems to be the case)?
Suggestions
- the tag/resource infor feels too far to the right
- the suggestions is scrollable ( the user won't know unless they look extreme right)
frontend/src/container/QueryBuilder/filters/QueryBuilderSearchV2/QueryBuilderSearchV2.tsx
Outdated
Show resolved
Hide resolved
@nityanandagohain did you use the back button to come back to the logs page ? if yes then it will retain the filter if you used stage and run query before leaving the page |
@nityanandagohain fixed the 2nd point as discussed, remaining will move to separate issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, please create issue for test and keep it in high priority so that we don't need to go through these tests again for one of the next pr's
@nityanandagohain also addressed the same name different data type issue. if no operator is entered until we show both and do not tokenise and once the operator comes we then pick on priority. |
created one P0 task on my name for the test cases - https://github.com/SigNoz/engineering-pod/issues/1724 cc @nityanandagohain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @srikanthccv do skim through the feature flag part once if somethng looks suspecious/missing, I have less context on it.
Summary
this pr adds the consumption for the new search bar v2 in the logs explorer page
Related Issues / PR's
contributes to #5150
Screenshots
NA
Affected Areas and Manually Tested Areas