-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: qs filter suggestions: example queries for multiple top attributes #5703
Merged
raj-k-singh
merged 13 commits into
develop
from
chore/qs-filter-suggestions-example-queries-for-multiple-top-attributes
Sep 9, 2024
Merged
Chore: qs filter suggestions: example queries for multiple top attributes #5703
raj-k-singh
merged 13 commits into
develop
from
chore/qs-filter-suggestions-example-queries-for-multiple-top-attributes
Sep 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raj-k-singh
force-pushed
the
chore/qs-filter-suggestions-example-queries-for-multiple-top-attributes
branch
2 times, most recently
from
August 15, 2024 14:36
9922cc6
to
1b3c363
Compare
raj-k-singh
force-pushed
the
chore/qs-filter-suggestions-example-queries-for-multiple-top-attributes
branch
2 times, most recently
from
September 3, 2024 14:06
3bbfa76
to
4ae819b
Compare
…r getting log attrib values
… for filter suggestions
raj-k-singh
force-pushed
the
chore/qs-filter-suggestions-example-queries-for-multiple-top-attributes
branch
from
September 4, 2024 05:18
340da51
to
ae1fb55
Compare
…es-for-multiple-top-attributes
srikanthccv
approved these changes
Sep 7, 2024
raj-k-singh
deleted the
chore/qs-filter-suggestions-example-queries-for-multiple-top-attributes
branch
September 9, 2024 04:42
nityanandagohain
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while not a blocker/urgent thing, but can use cache in future since it's already available. With ttl of around half an hour for getValuesForLogAttributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates filter suggestion API to return example queries for multiple suggested attributes.
v0 returned an example query for only the first suggested attribute
Related Issues / PR's
Contributes to #5609
Screenshots
Before
After
Affected Areas and Manually Tested Areas
Logs Query Builder