Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added blur event to having input in query section #5684

Merged
merged 8 commits into from
Sep 26, 2024
Merged

feat: added blur event to having input in query section #5684

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
89af688
feat: added blur event to having input in query section
rahulkeswani101 Aug 13, 2024
a63c36c
feat: added a error message for incomplete having clause and improved…
rahulkeswani101 Sep 4, 2024
162c707
feat: added focus event to remove error message
rahulkeswani101 Sep 5, 2024
ce9d8c6
Merge branch 'develop' into SIG-1364
rahulkeswani101 Sep 5, 2024
f807878
Merge branch 'develop' into SIG-1364
rahulkeswani101 Sep 15, 2024
90945c9
Merge branch 'develop' into SIG-1364
rahulkeswani101 Sep 19, 2024
a720f19
Merge branch 'develop' into SIG-1364
srikanthccv Sep 26, 2024
6c1e5a2
Merge branch 'develop' into SIG-1364
rahulkeswani101 Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions frontend/src/container/QueryBuilder/filters/HavingFilter/HavingFilter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,18 @@ export function HavingFilter({
resetChanges();
};

const handleBlur = useCallback((): void => {
if (searchText) {
const isValidSearch = isValidHavingValue(searchText);
rahulkeswani101 marked this conversation as resolved.
Show resolved Hide resolved
if (isValidSearch) {
const updatedLocalValues = [...localValues, searchText];
setLocalValues(updatedLocalValues);
onChange(updatedLocalValues.map(transformFromStringToHaving));
setSearchText('');
}
}
}, [searchText, localValues, onChange]);

useEffect(() => {
parseSearchText(searchText);
}, [searchText, parseSearchText]);
Expand Down Expand Up @@ -225,6 +237,7 @@ export function HavingFilter({
onDeselect={handleDeselect}
onChange={handleChange}
onSelect={handleSelect}
onBlur={handleBlur}
>
{options.map((opt) => (
<Select.Option key={opt.value} value={opt.value} title="havingOption">
Expand Down
Loading