-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rewrite the query builder search component #5659
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
vikrantgupta25
changed the title
feat: make the query builder search extensible
feat: rewrite the query builder search component
Aug 7, 2024
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
vikrantgupta25
force-pushed
the
query-builder-search-v2
branch
from
August 8, 2024 10:24
f462848
to
4d167f7
Compare
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
…use in logs explorer (#5712) * feat: query search new ui * feat: suggestions changes in v2 * feat: dropdown and tags ui touch up * feat: added missing keyboard shortcuts * fix: race condition issues * feat: remove usage
YounixM
reviewed
Aug 20, 2024
frontend/src/container/QueryBuilder/filters/QueryBuilderSearchV2/CustomDropdown.tsx
Outdated
Show resolved
Hide resolved
YounixM
reviewed
Aug 20, 2024
...end/src/container/QueryBuilder/filters/QueryBuilderSearchV2/QueryBuilderSearchV2.styles.scss
Outdated
Show resolved
Hide resolved
YounixM
reviewed
Aug 20, 2024
frontend/src/container/QueryBuilder/filters/QueryBuilderSearchV2/QueryBuilderSearchV2.tsx
Outdated
Show resolved
Hide resolved
YounixM
reviewed
Aug 20, 2024
frontend/src/container/QueryBuilder/filters/QueryBuilderSearchV2/QueryBuilderSearchV2.tsx
Outdated
Show resolved
Hide resolved
YounixM
reviewed
Aug 20, 2024
frontend/src/container/QueryBuilder/filters/QueryBuilderSearchV2/CustomDropdown.tsx
Outdated
Show resolved
Hide resolved
YounixM
reviewed
Aug 20, 2024
...end/src/container/QueryBuilder/filters/QueryBuilderSearchV2/QueryBuilderSearchV2.styles.scss
Outdated
Show resolved
Hide resolved
YounixM
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The change enables us to make further improvements in the design and performance / bugs of the query builder where clause. Also it includes the UI changes related to the dropdown and the search bar. Currently there is no usage of the new component in the product
Related Issues / PR's
partially fixes - #5150
Screenshots
Screen.Recording.2024-08-20.at.3.28.59.PM.mov
Affected Areas and Manually Tested Areas