Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable removing a selected field #5457

Merged
merged 4 commits into from
Jul 10, 2024
Merged

fix: disable removing a selected field #5457

merged 4 commits into from
Jul 10, 2024

Conversation

nityanandagohain
Copy link
Member

This will temporarily resolve the issue #4566 since it won't allow users to remove a selected field.

The message on the UI will look like this
image

How it affects the old explorer ?

  • Since selected fields are connect to what fields are displayed in the old UI, users wont be able to remove that once added.

How it affects the new explorer ?

@github-actions github-actions bot added the bug Something isn't working label Jul 9, 2024
@ankitnayan
Copy link
Collaborator

How displaying the type and dataType of a selected field is linked to this PR?

@nityanandagohain
Copy link
Member Author

@ankitnayan it's not directly linked.

I have just mentioned that the new logs explorer doesn't show type and dataType for mat columns.

Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mistakenly committed local db. Please remove it.

@nityanandagohain nityanandagohain merged commit 83455e6 into develop Jul 10, 2024
12 checks passed
@nityanandagohain nityanandagohain deleted the issue_4566 branch July 10, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants