feat(k8s-infra): introduce prometheus scraper using pod annotations #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prashant Shahi <[email protected]>
Signed-off-by: Prashant Shahi <[email protected]>
Signed-off-by: Prashant Shahi <[email protected]>
…s by default Signed-off-by: Prashant Shahi <[email protected]>
|
One issue with this will only work for minimal workloads. The pod will quickly face OOM issues for non-trivial workloads. When you get some time, please check how otel helm charts enable the Prom target allocator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #445
Fixes #196
This has been requested by lots of OSS and cloud users who wished to scrape metrics from various cluster and send to SigNoz running in different cluster.
This will be disabled in main chart by default where it is imported as dependency chart. Since, this would be redundant to that of metrics scarper in
otelCollectorMetrics. That would be required when people choose to not enable thek8s-infradependency chart itself but require the metrics scraper.Signed-off-by: Prashant Shahi [email protected]