Implement Main page & header; Implement pre-commit & pre-push & git actions(CI)#11
Merged
Merged
Conversation
- Remove package-lock.json (project uses pnpm) - Remove eslint-plugin-react-hooks from devDependencies (provided by eslint-config-react-app) - Remove redundant plugins config from eslintConfig - Regenerate pnpm-lock.yaml to sync with package.json
…ove vitest from lint-staged
- Exclude dist, node_modules, build, and coverage directories - Exclude test files from linting - This prevents linting compiled code in dist folder
- Fix import/first errors by moving imports to top of file - Apply consistent import ordering across game pages - Separate external imports from internal imports
- Remove unused 'response' variable in authApi.js - Remove unused 'data' import in myPage.js - Remove unused 'useNavigate' import in ErrorBoundary.jsx - Remove unused 'code' and 'setCode' in TypingBox.jsx - Remove unused 'initColors' variable
- Remove 'disconnectSocket()' call from HeaderV1.jsx - Add 'joinMeteoRoom' no-op shim in RoomCodeModal.jsx - Add 'onGoWaitingRoom' no-op shim in MeteoGamePage.jsx - These functions were removed but still referenced in code
- Remove .js extension from useVolumsStore import - Fixes module resolution error
- Add null check for codeId in useEffect - Fix Zustand subscribe signature (remove selector options) - Add null check in handleSubmit before calling addMessage - Fixes TS2538: Type 'null' cannot be used as an index type
- Import CheckboxRoot and CheckboxIndicator directly - Replace namespace import with named imports - Add explicit any type for onCheckedChange callback - Fixes TS2339: Property 'Root'/'Indicator' does not exist errors
- Add GetFollowersData interface for followers query - Add GetFollowingData interface for following query - Add GetUserProfileData interface for user profile query - Enables proper TypeScript type checking for GraphQL queries
- Add GetFollowersData/GetFollowingData type parameters - Use optional chaining for safer property access - Fix data shape in return values with items/pageInfo - Fixes TS2339: Property 'followers'/'following' does not exist
- Import and use GetUserProfileData type - Remove @ts-ignore comment - Use proper type parameter with useQuery - Fixes TS2638/TS2339: Type '{}' errors for GraphQL data
- Add 'as any' type assertions for preparePayment data - Fix ensurePortOneLoaded error handling (try-catch instead of .catch) - Add explicit types for verifyPayment response - Fixes TS2339: Property 'preparePayment'/'verifyPayment' does not exist
- Fix import paths in TypingBattlePage, Keyboard, VolumeSetting, MeteoGamePage - Resolves build error: Could not resolve '../../store/useVolumsStore'
- Vite requires imports without file extensions - Fixes build error: Could not resolve '../../store/useVolumsStore.js' - Build now completes successfully
…ub.com/SideProjectSFY/cloneNovaFE into feat/implement-main-page-and-header/#6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
#6
📝작업 내용
스크린샷 (선택)
💬리뷰 요구사항(선택)