Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move future block check into validateHeader #204

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Move future block check into validateHeader #204

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53a88af
consensus: move future block check into validateHeader
n8maninger Sep 17, 2024
a6c30a3
consensus: fix lint
n8maninger Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions consensus/validation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,16 @@ import (
"go.sia.tech/core/types"
)

var (
// ErrFutureBlock is returned when a block's timestamp is too far in the future.
ErrFutureBlock = errors.New("block's timestamp is too far in the future")
)

func validateHeader(s State, parentID types.BlockID, timestamp time.Time, nonce uint64, id types.BlockID) error {
if parentID != s.Index.ID {
return errors.New("wrong parent ID")
} else if timestamp.After(s.MaxFutureTimestamp(time.Now())) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes the function impure -- calling it at different times gives you different results. The current time should be passed in as an argument instead.

return ErrFutureBlock
} else if timestamp.Before(s.medianTimestamp()) {
return errors.New("timestamp is too far in the past")
} else if nonce%s.NonceFactor() != 0 {
Expand Down
Loading