consensus: Disallow contract revision after proof window opens #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a regression test with some tests of good and bad blocks? |
|
done |
n8maninger
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly worrisome that I missed this check when porting
siad... 👀This demonstrates why it's insufficient to rely on the fact that
corecan sync the existing chain: those are all valid blocks. Syncing mainnet tells us nothing about whethercorewill behave the same assiadwith respect to invalid blocks. So we should probably use the fuzzer to pass blocks to bothcoreandsiad, checking that either they both accept or both reject.