Skip to content

Add golangci-lint

Add golangci-lint #550

Triggered via pull request December 6, 2023 22:13
Status Failure
Total duration 33s
Artifacts

test.yml

on: pull_request
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

14 errors and 10 warnings
test (ubuntu-latest, 1.21): chain/manager.go#L861
`minumum` is a misspelling of `minimum` (misspell)
test (ubuntu-latest, 1.21): chain/db.go#L47
unnecessary trailing newline (whitespace)
test (ubuntu-latest, 1.21): consensus/state.go#L74
json(goCamel): got 'hardforkASIC' want 'hardforkAsic' (tagliatelle)
test (ubuntu-latest, 1.21)
issues found
test (ubuntu-latest, 1.20)
The job was canceled because "ubuntu-latest_1_21" failed.
test (ubuntu-latest, 1.20)
The operation was canceled.
test (windows-latest, 1.21)
The job was canceled because "ubuntu-latest_1_21" failed.
test (windows-latest, 1.21)
The operation was canceled.
test (windows-latest, 1.20)
The job was canceled because "ubuntu-latest_1_21" failed.
test (windows-latest, 1.20)
The operation was canceled.
test (macos-latest, 1.21)
The job was canceled because "ubuntu-latest_1_21" failed.
test (macos-latest, 1.21)
The operation was canceled.
test (macos-latest, 1.20)
The job was canceled because "ubuntu-latest_1_21" failed.
test (macos-latest, 1.20)
The operation was canceled.
test (ubuntu-latest, 1.21): internal/smux/stream.go#L150
if-return: redundant if ...; err != nil check, just return error instead. (revive)
test (ubuntu-latest, 1.21): gateway/gateway.go#L71
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
test (ubuntu-latest, 1.21): chain/db.go#L681
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
test (ubuntu-latest, 1.21): rhp/v2/rhp.go#L306
exported: exported type RPCCost should have comment or be unexported (revive)
test (ubuntu-latest, 1.21): rhp/v2/rhp.go#L314
exported: exported method RPCCost.Add should have comment or be unexported (revive)
test (ubuntu-latest, 1.21): rhp/v2/rhp.go#L324
exported: exported method RPCCost.Total should have comment or be unexported (revive)
test (ubuntu-latest, 1.21): consensus/validation_test.go#L1033
bool-literal-in-expr: omit Boolean literal in expression (revive)
test (ubuntu-latest, 1.21): consensus/validation_test.go#L1073
bool-literal-in-expr: omit Boolean literal in expression (revive)
test (ubuntu-latest, 1.21): consensus/validation_test.go#L1138
increment-decrement: should replace rev.RevisionNumber += 1 with rev.RevisionNumber++ (revive)
test (ubuntu-latest, 1.21): consensus/validation_test.go#L1292
struct-tag: malformed tag (revive)