Feat/contract 22 instance ttl bump#575
Merged
orunganiekan merged 2 commits intoJun 30, 2026
Merged
Conversation
[CONTRACT-22] DataKey::ActiveCount, FeeCollector, FeeBps, GracePeriod, WhitelistEnabled, Admin, and SchemaVersion all live in instance storage and share one TTL, but the contract never explicitly extended it. On Soroban mainnet, instance TTL is bounded — a contract gone dormant for long enough loses its Admin/Token keys and is effectively bricked. - New private bump_instance_ttl(env) helper, threshold SUBSCRIPTION_TTL_LEDGERS / 2, extend-to SUBSCRIPTION_TTL_LEDGERS (only writes when actually needed). - Called at the start of initialize and every state-mutating public function: subscribe/subscribe_with_metadata (via subscribe_inner), charge, pay_per_use, cancel, pause/pause_until, resume, propose_fee/commit_fee, propose_grace_period/commit_grace_period, set_whitelist_enabled, add_merchant/remove_merchant, batch_charge. - Read-only functions are untouched, per the issue's edge cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.