feat: resolve promise slice runtime crashes in ESG reporter (#675)#683
Open
knoxiboy wants to merge 1 commit into
Open
feat: resolve promise slice runtime crashes in ESG reporter (#675)#683knoxiboy wants to merge 1 commit into
knoxiboy wants to merge 1 commit into
Conversation
d62e49e to
e9561cd
Compare
Author
|
@Shruti070107 Please review this pr and merge it |
1 similar comment
Author
|
@Shruti070107 Please review this pr and merge it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #675
Description
This PR resolves the promise slice runtime TypeError crash in the Sustainability Hub view. By introducing
generateSyncHash, a high-performance, synchronous cryptographic-like hash fallback, we ensure that view rendering completes synchronously without returning unresolved Promises.What changed
generateSyncHashutility inESGReporterto produce synchronous SHA-256-like mock hashes for UI rendering.generateAuditHashcalls insiderenderHuband the verified activity ledger list elements withgenerateSyncHash.computeSecureHashandgenerateAuditHashAPIs for background operations like downloading the PDF report, preserving cryptographic security for downloads.Why
Calling the asynchronous
generateAuditHashfunction inside synchronous HTML templating/rendering paths returned a Promise object. Attempting to manipulate this Promise (e.g., calling.slice(0, 18)) led to immediate TypeError runtime crashes, rendering the Sustainability Hub tab entirely blank/broken.How to test
Checklist
Files Affected
src/esg-reporter.js