Skip to content

refactor: replace magic number with named constant in intensity calculation #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Akshita-2307 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: replace magic number with named constant in intensity calculation #655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/intelligence.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@
* @property {string} reason - Why this zone is predicted to be high demand.
*/

const MAX_ORDERS_FOR_FULL_INTENSITY = 10;

export const Intelligence = {
/**
* Predicts future waste volume based on historical data.
Expand Down Expand Up @@ -66,7 +68,7 @@ export const Intelligence = {
getHighDemandZones: (providers, allOrders) => {
return providers.map(p => {
const providerOrders = allOrders.filter(o => o.providerId === p.id);
const intensity = Math.min(providerOrders.length / 10, 1);
const intensity = Math.min(providerOrders.length / MAX_ORDERS_FOR_FULL_INTENSITY, 1);
return {
lat: p.lat + (Math.random() - 0.5) * 0.01, // Slight offset for visual "area"
lng: p.lng + (Math.random() - 0.5) * 0.01,
Expand Down