$DEBUG->ThemeCheck.debug?

$DEBUG is a standard ruby flag. It also logs all exceptions to STDERR.
When using the language server with this option, things were weird in
the logs pane. Since stuff kept getting logged even though the server
was closing and the exceptions were being caught.

This resulted in logs that stayed around instead of going away. Took me
way too long to figure that out. By moving to ThemeCheck.debug? instead,
this doesn't happen anymore.

exe/theme-check-language-server

@@ -3,9 +3,5 @@
 
 require 'theme_check'
 
-if ENV["THEME_CHECK_DEBUG"] == "true"
-  $DEBUG = true
-end
-
 status_code = ThemeCheck::LanguageServer.start
 exit! status_code

lib/theme_check.rb

@@ -51,6 +51,10 @@
 Encoding.default_internal = Encoding::UTF_8
 
 module ThemeCheck
+  def self.debug?
+    ENV["THEME_CHECK_DEBUG"] == "true"
+  end
+
   def self.with_liquid_c_disabled
     if defined?(Liquid::C)
       was_enabled = Liquid::C.enabled

lib/theme_check/language_server/bridge.rb

@@ -38,14 +38,14 @@ def log(message)
       def read_message
         message_body = @messenger.read_message
         message_json = JSON.parse(message_body)
-        @messenger.log(JSON.pretty_generate(message_json)) if $DEBUG
+        @messenger.log(JSON.pretty_generate(message_json)) if ThemeCheck.debug?
         message_json
       end
 
       def send_message(message_hash)
         message_hash[:jsonrpc] = '2.0'
         message_body = JSON.dump(message_hash)
-        @messenger.log(JSON.pretty_generate(message_hash)) if $DEBUG
+        @messenger.log(JSON.pretty_generate(message_hash)) if ThemeCheck.debug?
         @messenger.send_message(message_body)
       end