Handle ActiveRecord::Locking::LockingType #2014
Open
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have signed the CLA! |
amomchilov
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Hey Kevin, thanks for your first contribution!
Can you please credit @cquinones100 correctly by adding this to the end of your commit description:
Co-authored-by: NAME <[email protected]>
That'll make GitHub properly show you both as authors
|
There's some unrelated CI failures btw. I'm working through those now. |
ActiveRecord::Locking::LockingType is used for the lock_version column to handle Optimistic Locking: https://api.rubyonrails.org/classes/ActiveRecord/Locking/Optimistic.html - This type was falling into the else block and causing a Sorbet Error: Expected type ::Object, got type ActiveRecord::Locking::LockingType with value #<ActiveModel::Type::Intege...ange=-2147483648...2147483648> (SorbetError) The column_type is really just a wrapper for a potentially nilable integer, so we make a specific exception for it. Co-authored-by: Carlos Quinones <[email protected]> Co-authored-by: Alexander Momchilov <[email protected]>
kbruccoleri
force-pushed
the
handle-activerecord-locking-lockingtype
branch
from
507f1ab
to
2d5e3c4
Compare
|
@amomchilov Thanks for the feedback and the guidance, I have accepted all of your edits and updated the co-authors. |
|
@kbruccoleri Excellent! I'll follow up on this once I've sorted out the CI issues In the meantime, you please fix the lint failure? My hand-scribbled indentation suggestions were incorrect haha. bundle exec rubocop --auto-correct lib/tapioca/dsl/helpers/active_record_column_type_helper.rb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ActiveRecord::Locking::LockingTypeis used for thelock_versioncolumn to handle Optimistic Locking:https://api.rubyonrails.org/classes/ActiveRecord/Locking/Optimistic.html
This type was falling into the else block and causing a Sorbet Error:
Expected type ::Object, got type ActiveRecord::Locking::LockingType with value #<ActiveModel::Type::Intege...ange=-2147483648...2147483648> (SorbetError)Experiencing an issue after upgrading to latest Tapioca for Rails 7.2 compatibility.
Implementation
The
column_typeis really just a wrapper for a potentially nilable integer, so we make a specific exception for it.Tried to follow the convention around it with regards to determining if particular column is nilable or not.
Tests
No existing test file for
lib/tapioca/dsl/helpers/active_record_column_type_helper.rbShoutout to @cquinones100 for co-authoring