-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[minor] Scrip tags manager #1948
Open
lizkenyon
wants to merge
2
commits into
main
Choose a base branch
from
liz/add-scriptags-manager
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
# Script Tags | ||
|
||
ShopifyApp can manage your app's [Script Tags](https://shopify.dev/docs/admin-api/graphql/reference/online-store/scripttag) for you by setting which script tags you require in the initializer. | ||
> [!NOTE] | ||
> Script tags should only be used for vintage themes that do not support app blocks. | ||
|
||
## Configuration | ||
|
||
```ruby | ||
ShopifyApp.configure do |config| | ||
config.script_tags = [ | ||
# Basic script tag | ||
{cache: true, src: 'https://example.com/fancy.js'}, | ||
|
||
# Script tag with template_types for app block detection | ||
{ | ||
cache: true, | ||
src: 'https://example.com/product-script.js', | ||
template_types: ['product', 'collection'] | ||
} | ||
] | ||
end | ||
``` | ||
|
||
## Required Scopes | ||
Both the `write_script_tags` and `read_themes` scopes are required. | ||
|
||
For apps created with the Shopify CLI, set these scopes in your `shopify.app.toml` file: | ||
|
||
```toml | ||
[access_scopes] | ||
# Learn more at https://shopify.dev/docs/apps/tools/cli/configuration#access_scopes | ||
scopes = "write_products,write_script_tags,read_themes" | ||
``` | ||
|
||
For older apps, you can set the scopes in the initializer: | ||
|
||
```ruby | ||
config.scope = 'write_products,write_script_tags,read_themes' | ||
``` | ||
|
||
## How It Works | ||
|
||
### Script Tag Creation | ||
|
||
Script tags are created in the same way as [Webhooks](/docs/shopify_app/webhooks.md), with a background job which will create the required scripttags. | ||
|
||
### App Block Detection | ||
|
||
When you specify `template_types` for a script tag, ShopifyApp will check if the store's active theme supports app blocks for those template types. If any template type doesn't support app blocks, the script tags will be created as a fallback | ||
|
||
This allows your app to automatically adapt to the store's theme capabilities, using app blocks when available and falling back to script tags when necessary. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
# frozen_string_literal: true | ||
|
||
module ShopifyApp | ||
class ScriptTagsManagerJob < ActiveJob::Base | ||
queue_as do | ||
ShopifyApp.configuration.script_tags_manager_queue_name | ||
end | ||
|
||
def perform(shop_domain:, shop_token:, script_tags:) | ||
ShopifyAPI::Auth::Session.temp(shop: shop_domain, access_token: shop_token) do |session| | ||
manager = ScriptTagsManager.new(script_tags, shop_domain) | ||
manager.create_script_tags(session: session) | ||
end | ||
end | ||
end | ||
end |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i like the rename 👍