Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add debug message to callback rescue #1789

Merged
merged 1 commit into from
Feb 12, 2024
Merged

add debug message to callback rescue #1789

merged 1 commit into from
Feb 12, 2024

Conversation

uurcank
Copy link
Contributor

@uurcank uurcank commented Feb 9, 2024

This adds a log at debug level to the callback rescue. It does not feel right to quietly rescue and redirect here.

@uurcank uurcank requested a review from a team as a code owner February 9, 2024 20:06
paulomarg
paulomarg approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@paulomarg paulomarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agreed. We should ideally never have errors silently going away.

@paulomarg paulomarg merged commit 70c2366 into Shopify:main Feb 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulomarg paulomarg paulomarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uurcank @paulomarg