Repository navigation
Update @shopify/shopify-app-react-router to v4 and @shopify/polaris-types to v2 - #303
Merged
Merged
Conversation
github-actions
Bot
added
the
devtools-gardener
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
@shopify/shopify-app-react-router4.0.0 loads Polaris web components 2.x (polaris-2.js) by default instead ofpolaris.js, which stays on 1.x. Apps fromshopify app initare on^3.0.0, which never resolves to 4.x, so new apps keep loading Polaris 1.x until the template moves.WHAT is this pull request doing?
@shopify/shopify-app-react-routerto^4.0.0. The only change in 4.0.0 is the default Polaris URL. It was released as a major because new apps will now render with the Admin Next look. No template code changes are needed.@shopify/polaris-typesto^2.0.0. Otherwise new apps would load 2.x at runtime but typecheck against 1.x.This is the branch
shopify app initclones for TypeScript. Merging it triggers the conversion workflow, which updatesjavascript-cli_updates. #288 is the PR from that branch intojavascript-cli.Test this PR
pnpm installresolves@shopify/shopify-app-react-router@4.0.0and@shopify/polaris-types@2.0.0.typecheck,lintandbuildpass, andnpm installhits no dependency conflicts.https://cdn.shopify.com/shopifycloud/polaris-2.js.Checklist
README.mdfile and other related documentation, if applicableCHANGELOG.md