Skip to content

WIP: Add support for the new Test Discovery API #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Mar 11, 2025

TODO (possibly in follow-up PRs):

  • show test class name with UI
  • def test_ style mixed in same file as ActiveSupport declarative
  • dynamic references
  • building the test command

Note: For AS declarative tests, visibility (private) etc does not matter, unlike for normal minitest tests.

Closes Shopify/ruby-lsp#3179

wip

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@andyw8 andyw8 added the enhancement New feature or request label Mar 11, 2025
@andyw8 andyw8 changed the title WIP: Add support for the new API in the Rails add-on WIP: Add support for the new Test Discovery API Mar 11, 2025
@andyw8 andyw8 force-pushed the andyw8/discover-tests branch from 183115a to 6697213 Compare March 11, 2025 18:13
@andyw8 andyw8 force-pushed the andyw8/discover-tests branch from b02ab9e to d5728c5 Compare March 13, 2025 18:57
@andyw8 andyw8 force-pushed the andyw8/discover-tests branch from d5728c5 to 589e504 Compare March 13, 2025 19:01
@alexcrocha
Copy link
Contributor

Closing this Draft PR and continuing the work in #591

@alexcrocha alexcrocha closed this Apr 10, 2025
@vinistock vinistock deleted the andyw8/discover-tests branch April 10, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for the new API in the Rails add-on
2 participants