WIP: Server addons #438
Closed
WIP: Server addons #438
+582
−418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 26, 2024
andyw8
commented
Aug 27, 2024
| class << self | ||
| def require_server_addon(gem_name) | ||
| require "ruby_lsp/#{gem_name}/addon" | ||
| Object.const_get("RubyLsp::#{gem_name.classify}::Addon") # rubocop:disable Sorbet/ConstantsFromStrings |
There was a problem hiding this comment.
This assumes a naming convention such that foo_bar would have an addon named RubyLsp::FooBar::Addon.
andyw8
force-pushed
the
andyw8/tapioca-lsp
branch
from
e7ca765
to
715f97e
Compare
andyw8
commented
Aug 28, 2024
lib/ruby_lsp/ruby_lsp_rails/addon.rb
Outdated
| @@ -26,23 +26,27 @@ def initialize | |||
|
|
|||
| # We first initialize the client as a NullClient, so that we can start the server in a background thread. Until | |||
| # the real client is initialized, features that depend on it will not be blocked by using the NullClient | |||
| @client = T.let(NullClient.new, RunnerClient) | |||
| @rails_runner_client = T.let(NullClient.new, RunnerClient) | |||
There was a problem hiding this comment.
Renamed for clarity.
andyw8
commented
Aug 28, 2024
| @@ -170,6 +174,12 @@ def make_request(request, params = nil) | |||
| read_response | |||
| end | |||
|
|
|||
| # Notifications are like messages, but one-way, with no response sent back. | |||
There was a problem hiding this comment.
Made public so that addons can call it.
|
See #454 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for addons which need to running within a Rails context.
This is being initially aimed a supporting an LSP for Tapioca.
Related:
entries_formethod to indexer ruby-lsp#2500Co-authored with @KaanOzkan and @vinistock