Remove need for casting in rpc endpoint #248
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When digging into a some errors that were raised in this file I found there was a bunch of
as MessageMap[typeof SOMETHING]
casting happening because we structured this code in a way that typescript isn't able to infer data shapes on its own.This PR refactors the contents of this file so that the
data
variable is typed in a way that when you use theswitch
statement do different things based upon the value ofdata[0]
, the value ofdata[1]
is correctly narrowed to the expected type without the need for casting fromany
.Tophat
In vscode inspect the the type of the
data
/data[1]
values in within the switch statement by hovering over them and looking at what autcomplete tells you and see that they get correctly inferred.