-
Notifications
You must be signed in to change notification settings - Fork 220
Support numeric IDs in bulk operation status command #6694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bulk status|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3490 tests passing in 1408 suites. Report generated by 🧪jest coverage report action from 8dffee6 |
cfeef37 to
cce5d03
Compare
f5b51ec to
761814f
Compare
761814f to
af652b4
Compare
1eee310 to
84ffaa4
Compare
af652b4 to
ce702b4
Compare
84ffaa4 to
863dc89
Compare
|
/snapit |
|
🫰✨ Thanks @nickwesselman! Your snapshot has been published to npm. Test the snapshot by installing your package globally: npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/[email protected]Caution After installing, validate the version by running just |
packages/app/src/cli/services/bulk-operations/bulk-operation-status.ts
Outdated
Show resolved
Hide resolved
jordanverasamy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great change, love it, ty
ce702b4 to
d8d5b13
Compare
6b4b9cb to
e72bf3d
Compare
d8d5b13 to
ae93c9c
Compare
e72bf3d to
e7d4f1f
Compare
e7d4f1f to
8dffee6
Compare
gonzaloriestra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea supporting both!

WHY are these changes introduced?
Improves the user experience when working with bulk operations by supporting both numeric IDs and full GIDs.
WHAT is this pull request doing?
normalizeBulkOperationIdfunction to convert numeric IDs to GID formatextractBulkOperationIdfunction to display cleaner IDs in the UIHow to test your changes?
shopify app bulk queryorshopify app bulk mutationshopify app bulk status --id=123shopify app bulk status --id=gid://shopify/BulkOperation/123Measuring impact
How do we know this change was effective? Please choose one:
Checklist