Skip to content

Conversation

@nickwesselman
Copy link
Contributor

@nickwesselman nickwesselman commented Dec 6, 2025

WHY are these changes introduced?

Improves the user experience when working with bulk operations by supporting both numeric IDs and full GIDs.

WHAT is this pull request doing?

  • Adds support for using numeric IDs in addition to full GIDs when referencing bulk operations
  • Implements normalizeBulkOperationId function to convert numeric IDs to GID format
  • Adds extractBulkOperationId function to display cleaner IDs in the UI
  • Updates the bulk operation status table to show simplified numeric IDs
  • Improves the help text in the CLI command description to clarify ID format options
  • Enhances the status command suggestion message with better formatting

image.png

image.png

How to test your changes?

  1. Run a bulk operation using shopify app bulk query or shopify app bulk mutation
  2. Use the resulting operation ID in both formats:
    • With numeric ID: shopify app bulk status --id=123
    • With full GID: shopify app bulk status --id=gid://shopify/BulkOperation/123
  3. Verify both formats work correctly and the status display shows the simplified numeric ID

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@nickwesselman nickwesselman changed the title add support for integer IDs in bulk status Support numeric IDs in bulk operation status command Dec 6, 2025
@nickwesselman nickwesselman marked this pull request as ready for review December 6, 2025 21:06
@nickwesselman nickwesselman requested a review from a team as a code owner December 6, 2025 21:06
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2025

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.21% (-0.02% 🔻)
13916/17569
🟡 Branches
73.19% (+0.08% 🔼)
6799/9289
🟡 Functions
79.35% (-0.02% 🔻)
3565/4493
🟡 Lines
79.56% (-0.02% 🔻)
13147/16524
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / admin-as-app.ts
100% 100% 100% 100%
🟢
... / bulk-operation-run-mutation.ts
100% 100% 100% 100%
🟢
... / bulk-operation-run-query.ts
100% 100% 100% 100%
🟢
... / get-bulk-operation-by-id.ts
100% 100% 100% 100%
🟢
... / list-bulk-operations.ts
100% 100% 100% 100%
🟢
... / staged-uploads-create.ts
100% 100% 100% 100%
🔴
... / execute.ts
0% 0% 0% 0%
🔴
... / status.ts
0% 0% 0% 0%
🔴
... / pull.ts
0% 100% 0% 0%
🟢
... / execute-operation.ts
92.86% 80% 100% 92.31%
🔴
... / pull.ts
0% 0% 0% 0%
🟢
... / bulk-operation-status.ts
96.61% 92.11% 100% 100%
🟢
... / download-bulk-operation-results.ts
100% 100% 100% 100%
🟢
... / execute-bulk-operation.ts
92.98% 86.11% 100% 92.73%
🟢
... / format-bulk-operation-status.ts
100% 100% 100% 100%
🟢
... / run-mutation.ts
100% 100% 100% 100%
🟢
... / run-query.ts
100% 100% 100% 100%
🟡
... / stage-file.ts
72.73% 62.5% 83.33% 71.88%
🟢
... / watch-bulk-operation.ts
100% 100% 100% 100%
🟢
... / common.ts
96.15% 93.33% 100% 95.45%
🟢
... / execute-command-helpers.ts
100% 100% 100% 100%
🔴
... / promiseWithResolvers.ts
33.33% 50% 50% 33.33%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / execute.ts
0%
0% (-100% 🔻)
0% 0%
🟢
... / extension-instance.ts
84.8% (+0.23% 🔼)
77.6% (-0.91% 🔻)
92.06% (+0.13% 🔼)
85.11% (+0.24% 🔼)
🟡
... / specification.ts
69.09%
75.61% (+2.44% 🔼)
76.47% (-1.31% 🔻)
68.75%
🟢
... / ui_extension.ts
85.38% (-9.44% 🔻)
72.34% (-8.91% 🔻)
84% (-16% 🔻)
88% (-8.46% 🔻)
🟢
... / developer-platform-client.ts
84.62% (-1.5% 🔻)
73.68% (+3.1% 🔼)
81.82% (+1.82% 🔼)
90.63% (-2.71% 🔻)
🟢
... / api.ts
87.07% (-0.43% 🔻)
76.71% (-0.1% 🔻)
100%
86.49% (-0.43% 🔻)
🟢
... / ConcurrentOutput.tsx
98.36% (-1.64% 🔻)
92% (-4% 🔻)
100%
98.33% (-1.67% 🔻)
🟢
... / SingleTask.tsx
84.21% (-15.79% 🔻)
50% (-50% 🔻)
80% (-20% 🔻)
84.21% (-15.79% 🔻)
🔴
... / ui.tsx
50.82% (-0.79% 🔻)
42.86% (-5.53% 🔻)
54.55% (+1.42% 🔼)
50% (-0.82% 🔻)
🟢
... / console.ts
81.82% (+15.15% 🔼)
75% (-25% 🔻)
100% (+33.33% 🔼)
81.82% (+15.15% 🔼)
🔴
... / dev.ts
14.29% (+0.95% 🔼)
3.13% (+0.18% 🔼)
50% (-7.14% 🔻)
14.29% (+0.95% 🔼)
🟢
... / init.ts
88% (-0.89% 🔻)
71.43% (+4.76% 🔼)
86.67% (+4.85% 🔼)
88% (-0.89% 🔻)
🟢
... / storefront-renderer.ts
90.2% (-0.54% 🔻)
78.95%
81.82% (-1.52% 🔻)
90.2% (-0.54% 🔻)
🟡
... / theme-polling.ts
67.12% (-0.93% 🔻)
68.75% 78.57%
66.67% (-0.98% 🔻)

Test suite run success

3490 tests passing in 1408 suites.

Report generated by 🧪jest coverage report action from 8dffee6

@nickwesselman nickwesselman force-pushed the use_integer_for_status_id branch from cfeef37 to cce5d03 Compare December 6, 2025 21:15
@nickwesselman nickwesselman force-pushed the improve_info_box_for_graphql_commands branch from f5b51ec to 761814f Compare December 6, 2025 21:15
Copy link
Contributor Author

@nickwesselman nickwesselman requested a review from a team as a code owner December 6, 2025 21:19
@nickwesselman nickwesselman force-pushed the improve_info_box_for_graphql_commands branch from 761814f to af652b4 Compare December 6, 2025 21:20
@nickwesselman nickwesselman force-pushed the use_integer_for_status_id branch from 1eee310 to 84ffaa4 Compare December 6, 2025 21:20
@nickwesselman nickwesselman force-pushed the improve_info_box_for_graphql_commands branch from af652b4 to ce702b4 Compare December 6, 2025 21:28
@nickwesselman nickwesselman force-pushed the use_integer_for_status_id branch from 84ffaa4 to 863dc89 Compare December 6, 2025 21:28
Copy link
Contributor Author

/snapit

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2025

🫰✨ Thanks @nickwesselman! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/[email protected]

Caution

After installing, validate the version by running just shopify in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

Copy link
Contributor

@jordanverasamy jordanverasamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great change, love it, ty

@nickwesselman nickwesselman force-pushed the improve_info_box_for_graphql_commands branch from ce702b4 to d8d5b13 Compare December 9, 2025 20:20
@nickwesselman nickwesselman force-pushed the use_integer_for_status_id branch from 6b4b9cb to e72bf3d Compare December 9, 2025 20:20
@nickwesselman nickwesselman force-pushed the improve_info_box_for_graphql_commands branch from d8d5b13 to ae93c9c Compare December 10, 2025 14:13
@nickwesselman nickwesselman force-pushed the use_integer_for_status_id branch from e72bf3d to e7d4f1f Compare December 10, 2025 14:13
Base automatically changed from improve_info_box_for_graphql_commands to main December 10, 2025 14:31
Copy link
Contributor

@gonzaloriestra gonzaloriestra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea supporting both!

@nickwesselman nickwesselman added this pull request to the merge queue Dec 11, 2025
Merged via the queue into main with commit bc6326c Dec 11, 2025
25 checks passed
@nickwesselman nickwesselman deleted the use_integer_for_status_id branch December 11, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants