Skip to content

Adds Join method #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jreina wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Adds Join method #109

jreina wants to merge 1 commit into from

Conversation

@jreina
Copy link
Member

@jreina jreina commented Oct 14, 2018 •
edited
Loading

ref #48
Probably should've just let someone else do this one.

@jreina
Added super flaky join method.
00dd318 
Probably should've just let someone else do this one.
@jreina
Copy link
Member Author

jreina commented Oct 14, 2018

@CooRay @the-pat @willCode2Surf can one of y'all look over this and suggest changes/better ways to test? I'm pretty lost on how to do this.

@the-pat
Copy link
Contributor

the-pat commented Oct 15, 2018

Instead of using multiple Asserts, the unit testing framework provides a CollectionAssert.

@jreina
Copy link
Member Author

jreina commented Oct 15, 2018

@the-pat that helps tremendously. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jreina @the-pat