Robust multi-step pre-screening flow (navigation, validation, progre…#1300
Merged
Conversation
|
@Nemenwq is attempting to deploy a commit to the pope-h's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Nemenwq Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The pre-screening flow has been refactored with all acceptance criteria met:
closes #1271
Summary of Changes
Step stored in URL query parameter (?step=N)
Refresh preserves current step and form data
URL syncs with step changes using useRouter and usePathname
2. Form Validation (formSchemas.ts)
Added preScreenSchema with Zod validation for all fields
Integrated useAppForm hook for form management
Per-step validation blocks invalid advancement
First error field auto-focused on validation failure
3. Enhanced Progress Indicator
Added "Step N of M" text display
Percentage completion indicator
Visual step indicator with completed/current/pending states
4. Accessibility Features
Keyboard navigation with proper focus states
ARIA labels, roles, and live regions for screen readers
Step change announcements via aria-live="polite"
Error messages announced with aria-describedby and aria-invalid
All form fields properly labeled
Focus management on validation errors
5. Data Preservation
Back/forward navigation preserves form data via react-hook-form state
Draft auto-save via useAppForm's localStorage integration
Resume prompt for users with saved drafts
6. Clear End Result
EligibilityResultCard displays pass/fail status
Clear next steps (Browse Properties / Start Over)
Linked issue (recommended)
Example:
Closes #123Changes
This section is required for CI PR validation.
Contract Upgrade Details (if applicable)
This section is required for CI PR validation if this is a contract upgrade.
Network
New Contract
C...sha256:...G...[link to transaction explorer]Upgrade Governance
Verification Steps
How to test
This section is required for CI PR validation.
Security Considerations
This section is required for CI PR validation.
Screenshots (if UI)
Include before/after screenshots for any UI changes. For new features, show different states (loading, error, success). For responsive changes, include mobile/tablet/desktop views.
Checklist
This section is required for CI PR validation.