V4.0 Lucene 4.8.0-beta00017 breaking changes #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will get to this soon, there's been some changes in v3 that were required, also relating to replicator, etc... Still waiting on community feedback but once that is shipped, the re-merge of v3 - v4 with additional fixes will be in place. |
|
I tried building this PR, and replaced it on an existing site with the v4.0.0-beta-1 (in order to be able to upgrade Umbraco to 13.7.1). Seems to work ok! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've attempted to address the problems raised in #401, relating to breaking changes in the version
4.8.0-beta00017Lucene packages.The code now compiles with the beta00017 packages, utilizing the
SnapshotDirectoryTaxonomyIndexWriterFactoryclass from Lucene, however there are three unit tests that now fail which previously succeeded. These are:GivenASyncedLocalIndex_WhenTriggered_ThenSyncedBackToMainIndexGivenASyncedLocalIndex_ThenSyncedBackToMainIndexOnScheduleGivenAMainIndex_WhenReplicatedLocally_TheLocalIndexIsPopulatedThe problem lies in the changed implementation of the
ReplicateIndexmethod, as I have been unable to figure out exactly how to get it working properly. It now throwsSystem.InvalidOperationException: 'No index commit to snapshot', which results in the method returning early before it can fully completing the work of the method.I hope I've done a bit of the work, perhaps someone else more knowledgeable can fix up the remaining outstanding problems.