Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify access requirements for Search on SharePoint Embedded #10184

Conversation

dluces
Copy link
Contributor

@dluces dluces commented Apr 4, 2025

Category

  • Content fix
  • New article

Related issues

  • fixes n/a
  • partially n/a
  • mentioned in n/a

What's in this Pull Request?

We are instructing callers to request two scopes when using Microsoft Graph Search for SharePoint Embedded content: Files.Read.All (exceptional access pattern) and FileStorageContainer.Selected (future contract). This will ensure their implementation is ready for the time when the contract aligns with the rest of the SPE model.

Also, made the note for exceptional access patterns important instead.

Copy link
Contributor

Learn Build status updates of commit df0eb63:

✅ Validation status: passed

File Status Preview URL Details
docs/embedded/development/auth.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 5f6586e:

✅ Validation status: passed

File Status Preview URL Details
docs/embedded/development/auth.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@dluces
Copy link
Contributor Author

dluces commented Apr 8, 2025

Interestingly, I'm not able to use the request review feature in PRs :) Pinging Cindy for interim approval

@cindylay
Copy link
Contributor

cindylay commented Apr 9, 2025

Changes to auth article look good, ready to merge. I don't see an approve button only a merge button

@andrewconnell andrewconnell self-assigned this Apr 9, 2025
@andrewconnell andrewconnell self-requested a review April 9, 2025 12:25
@andrewconnell andrewconnell added the pr:in-review Actively reviewing pull request label Apr 9, 2025
@andrewconnell andrewconnell requested a review from cindylay April 9, 2025 12:26
Copy link
Contributor

Learn Build status updates of commit f36af14:

✅ Validation status: passed

File Status Preview URL Details
docs/embedded/development/auth.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@cindylay
Copy link
Contributor

cindylay commented Apr 9, 2025

Apologies, didn't have the review button in the top right-- approved now

@andrewconnell andrewconnell added pr:ready-to-merge Ready to merge PR and removed pr:in-review Actively reviewing pull request labels Apr 9, 2025
@andrewconnell andrewconnell merged commit 2129022 into SharePoint:main Apr 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-to-merge Ready to merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants