Documentation Restructure #10025
Open
Documentation Restructure #10025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing limits and calling patterns
updating main branch
|
Learn Build status updates of commit b5449e3:
|
|
Learn Build status updates of commit 1f09ce0:
|
|
Learn Build status updates of commit 29f3dfd:
|
|
Learn Build status updates of commit 4a756b5:
|
|
Learn Build status updates of commit 7187aa0:
|
|
@cindylay ... here are a few broken links I found:
|
andrewconnell
requested changes
Jan 29, 2025
There was a problem hiding this comment.
Due to renaming/moving files around, there are now a significant number of broken links this PR will create. I've found a bunch & added line-item reviews, but after fixing, please review the FULL automated build report.
The @learn-build-service-prod bot does automated checks after each commit that's part of a PR and reports findings. Some warnings, especially broken links, can't be ignored and must be addressed.
Be aware that the build report comment from the @learn-build-service-prod bot only contains the first 25 findings... at the end of the comment, it links to the full build report. Look at the Validated Files section for a full list of all errors/warnings that should be addressed before this PR can get merged.
REF: in this comment by @learn-build-service-prod, near the end, you'll see the following:
This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request. For more details, please refer to the build report.
The build report text links to the full build report.
| @@ -54,7 +55,7 @@ To get started using PowerShell to manage SharePoint Embedded, you have to insta | |||
|
|
|||
| ### Creation of container types | |||
|
|
|||
| The developer administrator can create a container type using PowerShell cmdlets. Each container type is associated to an application ID, a one to one mapping, and an Azure subscription ID. The developer administrator can also create Trial container types that have a validity of 30 days to test out SharePoint Embedded. The following commands can be used to create SharePoint Embedded container types on the developer admin’s tenant: | |||
| The developer administrator can create a container type using PowerShell cmdlets. Each container type is associated to an application ID, a one to one mapping, and an Azure subscription ID. The developer administrator can also create Trial container types that have a validity of 30 days to test out SharePoint Embedded. The following [commands](https://learn.microsoft.com/en-us/powershell/module/sharepoint-online/new-spocontainertype?view=sharepoint-ps) can be used to create SharePoint Embedded container types on the developer admin’s tenant: | |||
There was a problem hiding this comment.
Per the automated build report, Invalid link - please fix:
- don't use absolute links, use relative links
- don't include locale in link
- remove the preview link from the URL - target page only has powershell code listings, so no need to set the view
There was a problem hiding this comment.
See the automated build report
this page will now have a 404 link on line 28 due to a moved/renamed file as part of this PR
please fix
There was a problem hiding this comment.
See the automated build report
this page will now have 404 links on lines 117 & 118 due to a moved/renamed files as part of this PR
please fix
|
|
||
| This example queries container content by specific words and requires the response to include all specified attributes on the content. | ||
| This example queries container content by specific words and requires the response to include all specified attributes on the content. Properties that are [sortable](https://learn.microsoft.com/en-us/sharepoint/technical-reference/crawled-and-managed-properties-overview) can be used to sort the results. |
There was a problem hiding this comment.
Per automated build report findings, invalid link:
- no absolute links, use relative
- no hard-coded locale in URL... remove
|
|
||
| - Search requests run in the context of the signed-in user. Search results are only scoped to enforce any access control applied to the items by the user. For example, search results will include all container or container content matching the search criteria and accessible by the user regardless of whether the SharePoint Embedded application is authorized to access. You should specify the desired container type by including the ContainerTypeId as part of your **queryString** when searching for containers or container content to ensure search results are properly scoped. | ||
| - For your application to access the containers or container content in search results, it must have access permissions to the corresponding container types. | ||
|
|
||
|
|
||
| # Enumerate (filter) SharePoint Embedded content |
There was a problem hiding this comment.
can't have multiple H1's on a page, must fix
| @@ -15,8 +15,8 @@ Container type is represented on each container instance as an immutable propert | |||
|
|
|||
| - Access authorization. A SharePoint Embedded application must be associated with a container type to get access to container instances of that type. Once associated, the application has access to all container instances of that type. The actual access privilege is determined by the application-ContainerTypeID permission setting. The owning application by default has full access privilege to all container instances of the container type it's strongly coupled with. Learn more about [SharePoint Embedded Authorization](../app-concepts/auth.md). | |||
There was a problem hiding this comment.
link will be 404 when merging, must fix to point to correct path
| @@ -97,11 +97,11 @@ Region : EastUS | |||
|
|
|||
| ## Registering Container Types | |||
|
|
|||
| To create and interact with containers, you must [register](../app-concepts/register-api-documentation.md) the container type within the Consuming Tenant. The owning application defines the permissions for the container type by invoking the [registration API](../app-concepts/register-api-documentation.md). | |||
There was a problem hiding this comment.
invalid link will create 404
must fix
There was a problem hiding this comment.
this PR will cause the following links on this page to be 404's - must fix:
- line 59
- line 63
| - name: User Experiences | ||
| href: embedded/development/content-experiences/user-experiences-overview.md | ||
| - name: Search Content | ||
| href: embedded/concepts/content-experiences/search-content.md |
There was a problem hiding this comment.
invalid link, must fix
| - name: Compliance | ||
| items: | ||
| - name: Security and Compliance | ||
| href: embedded/concepts/security-and-compliance.md |
There was a problem hiding this comment.
invalid link, must fix
andrewconnell
added
Needs: Author Feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category
Making this pull request draft so that we are able to see content previews of documentation on review.learn.microsoft.com. Resolved a previous merge conflict in an older pull request and closed it and deleted the branch.