Feature: User Option for Setting the Drone Octave#333
Open
pedxyuyuko wants to merge 8 commits intoShacharHarshuv:masterfrom
Open
Feature: User Option for Setting the Drone Octave#333pedxyuyuko wants to merge 8 commits intoShacharHarshuv:masterfrom
pedxyuyuko wants to merge 8 commits intoShacharHarshuv:masterfrom
Conversation
|
@pedxyuyuko is attempting to deploy a commit to the shacharharshuv's projects Team on Vercel. A member of the Team first needs to authorize it. |
Owner
ShacharHarshuv
left a comment
ShacharHarshuv
left a comment
There was a problem hiding this comment.
Amazing! Nice job.
Added some minor comments about naming and text. Will merge after fixed.
src/app/exercise/exercises/utility/exerciseAttributes/tonalExercise.spec.ts
Outdated
Show resolved
Hide resolved
src/app/exercise/exercises/utility/exerciseAttributes/tonalExercise.spec.ts
Outdated
Show resolved
Hide resolved
src/app/exercise/exercises/utility/exerciseAttributes/tonalExercise.spec.ts
Outdated
Show resolved
Hide resolved
src/app/exercise/exercises/utility/exerciseAttributes/tonalExercise.ts
Outdated
Show resolved
Hide resolved
src/app/exercise/exercises/utility/exerciseAttributes/tonalExercise.ts
Outdated
Show resolved
Hide resolved
src/app/exercise/exercises/utility/exerciseAttributes/tonalExercise.ts
Outdated
Show resolved
Hide resolved
src/app/exercise/exercises/utility/exerciseAttributes/tonalExercise.ts
Outdated
Show resolved
Hide resolved
src/app/exercise/exercises/utility/exerciseAttributes/tonalExercise.ts
Outdated
Show resolved
Hide resolved
Author
|
Done. Sry I don't have a proper configured TS/JS linter so its kinda messy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a hard time singing the drone and comparing the given tone to it because the drone is in lower register (1st, 2nd octave). So I add an option to modify its octave.
Here is a preview of the setting menu:
Setting the Drone Octave to 3rd will make the app play C3 instead of default C2.
Any suggestion will be appreciated!