Replace route notation to be SF6 compatible, and use path_name parameter for admin prefix #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase on master? I just merged #88 |
delyriand
force-pushed
the
fix/admin-routes
branch
from
4b2372e
to
ab8fa3b
Compare
|
@loevgaard done |
|
Is it possible for you to fix the build? |
|
@loevgaard it's not linked to this PR, there are the same errors on master: https://github.com/Setono/SyliusFeedPlugin/actions/runs/7711190968 I don't have time to watch your build |
|
Okay, thank you |
delyriand
force-pushed
the
fix/admin-routes
branch
from
ab8fa3b
to
08d3d4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid 404s if the admin path is modified via the env variable