Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This is my first contribution to hacktober fest and I have included b… #76

Conversation

kumarinisha378
Copy link

…oth user and points to the message entry.

@kumarinisha378
Copy link
Author

Added an entry to Thing > Messages(x_snc_pointsthing_message)
followed the message example as 'Congrats ' + user + ' you now have ' + points + ' points';

Created this message: 'Participating for the 1st time. This '+user+ ' has scored a' +points + ' points.'

clicked install and upgrades by right-clicking on the list header and choose "Create Application Files"
committed changes to source control

@SapphicFire SapphicFire self-assigned this Oct 30, 2024
Copy link
Contributor

@SapphicFire SapphicFire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. However, this submission is not suitable for this repository in its current state. We encourage contributors to review the project's objectives and guidelines (see the README.md and CONTRIBUTING.md files) before submitting pull requests. Closing this for now. Once you make additional changes, feel free to re-open this Pull Request or create a new one.

<documentkey>4ea905e1c36d5a10a8361dd1b40131ec</documentkey>
<payload>&lt;?xml version="1.0" encoding="UTF-8"?&gt;&lt;record_update table="x_snc_pointsthing_message"&gt;
&lt;x_snc_pointsthing_message action="INSERT_OR_UPDATE"&gt;
&lt;message&gt;&lt;![CDATA['Participating for the 1st time. This '+user+ ' has scored a' +points + ' points.']]&gt;&lt;/message&gt;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not use correct grammar and does not have correct spacing. Additionally, the message about participation isn't suitable for this repo. This should be a celebration or kudos message, particularly for a milestone like 1000 points

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants