Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibGfx/ISOBMFF: Add support for jpeg2000 cmap and bpcc boxes #25660

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nico
Copy link
Contributor

@nico nico commented Jan 19, 2025

This completes support for all jpeg2000 boxes in I.5.3.

cmap demo, for the file attached to #25656, before:

% Build/lagom/bin/isobmff out_71.jpx  
...
  ('cmap')
  [ 16 bytes ]
('jp2c')
- codestream = 2448 bytes

After:

% Build/lagom/bin/isobmff out_71.jpx  
...
  ('cmap')
  - component_index = 0
  - mapping_type = 1
  - palette_component_index = 0
  - component_index = 0
  - mapping_type = 1
  - palette_component_index = 1
  - component_index = 0
  - mapping_type = 1
  - palette_component_index = 2
  - component_index = 0
  - mapping_type = 1
  - palette_component_index = 3
('jp2c')
- codestream = 2448 bytes

I haven't seen the bpcc box in the wild yet, but it's the only missing box type in I.5.3 and it's similar to to a subset of palette box in I.5.3.4, so maybe the implementation is not completely wrong.

nico added 3 commits January 18, 2025 20:54
I haven't seen this in the wild yet, but it's the only missing
box type in I.5.3 and it's similar to to a subset of palette box
in I.5.3.4, so maybe the implementation is not completely wrong.
No behavior change in practice, just nice for tidiness.
@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👀 pr-needs-review PR needs review from a maintainer or community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant