fix: make test actually fails when tests fail instead of always exiting 0 - #88
Merged
Senthil455 merged 1 commit intoJun 17, 2026
Merged
Conversation
…ng 0 The make test target used || true on every test command, so it always exited with code 0 even when tests failed. This gave false green status in CI pipelines and hid regressions. Instead of blindly removing || true (which would make make abort at the first failure and skip remaining services), this change captures each test exit code in a variable so all services run regardless. If any test fails, the target exits with code 1 after all have finished.
Collaborator
Author
|
Thanks for the thorough review! Glad the double-escaped dollar sign checked out. No changes needed — merging as-is. |
Senthil455
reviewed
Jun 17, 2026
Senthil455
left a comment
Owner
There was a problem hiding this comment.
gh: Not Found (HTTP 404)
{"message":"Not Found","documentation_url":"https://docs.github.com/rest/issues/comments#get-an-issue-comment","status":"404"}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #53
What was wrong
Every test command in the \make test\ target used || true, so the target always exited with code 0. This meant:
What changed
The fix replaces || true\ with a shell variable that tracks failures across all services:
\\makefile
@failed=0;
cd services/api-gateway-node && npm test || failed=1;
...
if [ failed -ne 0 ]; then exit 1; fi;
\\
This runs every service's test suite regardless of individual failures, then exits with code 1 if any test failed. No more silent swallowing of failures.
Why not just remove || true
Simply dropping || true\ would make make abort at the first failing service and skip the rest. The chosen approach runs all tests and reports the overall result, which is more useful for developers iterating on multiple services.