fix: remove ambiguous numeric 'id' from Employee type - #81
Merged
Senthil455 merged 1 commit intoJun 17, 2026
Merged
Conversation
The Employee type had both _id (MongoDB string) and id (number) as optional fields, creating ambiguity about which identifier to use. - Remove id?: number — has no backend counterpart and is never used - Keep _id?: string — the backend returns MongoDB ObjectId as string, kept optional for creation scenarios where _id is not yet assigned The actual unique identifier used throughout the codebase is email, which all CRUD API routes use as the lookup key.
Senthil455
reviewed
Jun 17, 2026
Owner
There was a problem hiding this comment.
Changes
etwork: external: true to driver: bridge in docker-compose.monitoring.yml.
This looks good — external: true requires the network to already exist, which can cause startup failures in fresh environments. Using driver: bridge lets Docker Compose create it automatically. No issues found, ready to merge.
Collaborator
Author
|
Thank you for the review! No additional changes needed — merging as-is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The \Employee\ type in \ rontend/src/types/index.ts\ had both _id\ (MongoDB string) and \id\ (number) declared as optional fields, creating ambiguity about which identifier to use in API calls (#62).
Changes
Context
All employee CRUD API routes (\GET, \PUT, \DELETE) use \email\ as the unique lookup key. Neither _id\ nor the removed numeric \id\ is passed to any API endpoint. The effective identifier throughout the codebase is \email.
Verification