fix: add SAML response XML digital signature verification to prevent … - #3
Merged
Senthil455 merged 2 commits intoJun 14, 2026
Conversation
…auth bypass Security Fix The SAML ACS endpoint (POST /saml/acs) previously decoded the base64 SAMLResponse and extracted user attributes via regex without verifying the XML digital signature. This allowed anyone with a crafted SAMLResponse to impersonate any user. Changes: - Added @xmldom/xmldom and xml-crypto dependencies - Added SAML_IDP_CERT environment variable for IdP public certificate - Parse SAML XML and verify ds:Signature before processing assertions - If SAML_IDP_CERT is configured, reject unsigned or invalid signatures - Signature verification uses X.509 certificate from environment config - Backward compatible: if SAML_IDP_CERT is empty, no verification is performed (dev mode); log a warning in this case
DivyashreeR008
referenced
this pull request
in DivyashreeR008/Atlas-Workforce-System
Jun 17, 2026
…fication fix: add SAML response XML digital signature verification to prevent …
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…auth bypass
Security Fix
The SAML ACS endpoint (POST /saml/acs) previously decoded the base64 SAMLResponse and extracted user attributes via regex without verifying the XML digital signature. This allowed anyone with a crafted SAMLResponse to impersonate any user.
Changes: