fix: fail CI on lint/tsc errors, add Docker builds and security scanning - #17
Merged
Conversation
Senthil455
commented
Jun 17, 2026
Senthil455
left a comment
Owner
Author
There was a problem hiding this comment.
gh: Not Found (HTTP 404)
{"message":"Not Found","documentation_url":"https://docs.github.com/rest/issues/comments#get-an-issue-comment","status":"404"}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixed three CI issues: lint/tsc errors silently passing, no Docker builds, no security scanning.
What changed:
line 31): Removed|| echo "Lint warning"— lint errors now fail the buildline 33): Removed|| true— TypeScript errors now fail the buildnpm testto Frontend CIdocker-buildjob — builds all 9 service images using Docker Buildx with GitHub Actions cache. Pushes toghcr.ioon push events, only builds on PRs.security-scanjob — filesystem Trivy scan for HIGH/CRITICAL vulnerabilities, uploads SARIF results to GitHub Security tab