fix: add JWT authentication to all WebSocket endpoints in live-service - #14
Merged
Conversation
- Created verify_ws_token() that validates JWT from query param or header
- WebSocket endpoints now reject unauthenticated connections with 4001
- Applies to /ws/{channel}, /ws/chat, and /ws/presence
- Uses existing INTERNAL_JWT_SECRET for token verification
- Accepts token via ?token= query parameter or x-internal-auth header
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue 5: Live Service WebSocket endpoints have zero authentication
Security - All three WebSocket endpoints were completely unauthenticated:
The HTTP middleware (@app.middleware(http)) does not intercept WebSocket connections.
Fix
Files changed