fix: add role-based access control to all Java services - #11
Merged
Conversation
- Remove token from localStorage (XSS-vulnerable) - Store token in-memory only, set httpOnly cookie for middleware - Add /api/auth/token endpoint to restore token from cookie on refresh - Update AuthGuard to initialize auth from cookie on mount
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
All Java services (payroll, performance, leave) had no role-based access control on ~95% of endpoints. The existing InternalAuthFilter sets x-user-role as a request attribute, but no enforcement was applied at the controller level. The two ad-hoc checks that existed read from X-User-Role header instead of the request attribute set by the filter, making them ineffective.
Solution
Implemented declarative RBAC via a @RequiresRole annotation with an AOP aspect in all 3 Java services.
Architecture
Endpoints protected
Fixes