Add Support for "Move Workspace File" API Endpoint#15
Open
neves-nvs wants to merge 3 commits intoSendSafely:masterfrom
Open
Add Support for "Move Workspace File" API Endpoint#15neves-nvs wants to merge 3 commits intoSendSafely:masterfrom
neves-nvs wants to merge 3 commits intoSendSafely:masterfrom
Conversation
Author
|
@SendSafely-GitHub I would like some feedback on this if possible. Also, went to look into other packages:
|
Collaborator
|
Thank you @neves-nvs and @hobelinm. We have passed this on to our internal team that maintains the Python Client and will let you know once they review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This pull request introduces an ad-hoc implementation to interact with an additional endpoint of the SendSafely API that is currently not supported by this package. The existing Python package for SendSafely does not expose this endpoint, so I’ve implemented the necessary functionality to support interactions with it. This was added based on our specific needs for file management within workspaces.
Changes Made:
Notes:
The additions are:
Package.move_file_to_directory(self, file_id, directory_id)class MoveFileExceptionThese were named in alignment with the existing methods in the package. However, there are some inconsistencies across the documentation:
These naming variations are noted for consistency with the rest of the package, but I believe the current names are clear and follow the existing patterns in the package.