Repository navigation
Conversation
cquil11
marked this pull request as ready for review
October 6, 2026 15:58
cquil11
added this pull request to stack #48
October 6, 2026 16:29
Signed-off-by: Cam Quilici <cjquilici@gmail.com>
cquil11
force-pushed
the
feat/docker-launcher
branch
from
October 12, 2026 16:37
b2b401e to
bd2b94d
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #47 (single-node Docker launcher). This PR adds only the multi-node part:
DockerLauncherruns a job's processes across several Docker hosts.Design
docker_hostsinsrtslurm.yamllists the job's nodes and defaults to this machine. The orchestrator runs wheresrtctl applyruns and carvesdocker_hostsinto roles with the sameNodes.from_nodelista Slurm nodelist uses, so aggregated, multi-node aggregated and disaggregated recipes need no changes.validate()now checks the recipe's node count againstdocker_hosts; the single-node checks on dedicated frontend, benchmark or infra nodes and on service pools are removed, since with several hosts those are just more nodes.LaunchSpecruns one task on each node in itsnodelist. Each task is adocker run --gpus all --network host --ipc hostcontainer, started directly on this machine and throughssh -n -o BatchMode=yes <node>on any other node. A launch that targets several nodes (the exporters) starts one task per node in parallel, and%Nin the log path becomes the node name, as with srun.127.0.0.1. With several,node_ipruns the existingip_utils/get_node_ip.shlookup on the target node over ssh, sonetwork_interfacebehaves as it does under Slurm.docker kill --signal=...on its node, because killing the localsshordocker runclient does not stop the container. When the job script exits, any container labelledsrtctl.job=<job_id>that is still running is removed on every host.ssh -tt, so it gets SIGHUP when its ssh client is signalled; host steps are stopped by signalling their local process group. Without this, the remote process kept running after the job.outputs/, the srtctl checkout) must exist at the same path on every host, as on a Slurm cluster's shared filesystem.Validation
Run on
h200, on two nodes held withsalloc(worker-12 and worker-13). Each node had Docker 29.2.1 and NVIDIA H200 GPUs.srtctl applyran on worker-12 withlauncher: docker. Model: Qwen3-0.6B (bf16). Image:lmsysorg/sglang:v0.5.20. Benchmark: sa-bench at ISL/OSL 128/128, concurrencies 4 and 8. All three runs used tree51a61e2b, which is identical to this branch's tree after the merge of #47.docker_hosts--dist-init-addrset to worker-12's node IP; 40/40 and 80/80 requests completed; no containers or host exporters left on either nodeA failed run (the prefill worker exited on a startup flag) stopped the job and removed both nodes' containers.