Skip to content

Isolate job-local Dynamo installation changes - #15

Draft
cquil11 wants to merge 3 commits into
upstream/amd-runtimefrom
review/dynamo-install-isolation
Draft

cquil11 wants to merge 3 commits into
upstream/amd-runtimefrom
review/dynamo-install-isolation

Conversation

@cquil11

@cquil11 cquil11 commented Sep 15, 2026

Copy link
Copy Markdown

Scope

Extract the Dynamo installation changes from NVIDIA#431 without changing their implementation. AMD hardware enablement should not change NVIDIA/Dynamo dependency installation.

  • Preserve the existing job-local package overlay, dependency-preserving pip flags, and install-lock behavior for separate review.
  • Keep the associated configuration-command tests with the implementation.

Review concerns

This is deliberately draft: container/Python-environment isolation and shared-filesystem lock scope need independent review. It is not required merely because hardware is AMD, and the AgentX native-SGLang sweep does not validate Dynamo. No Dynamo E2E claim is made.

The AMD validation integration can retain this commit to preserve the previously combined implementation; merging the AMD base does not merge these installation changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant