Repository navigation
Conversation
This was referenced Sep 15, 2026
cquil11
force-pushed
the
upstream/amd-runtime
branch
5 times, most recently
from
September 22, 2026 18:13
1086678 to
4b5f7e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Extract the Dynamo installation changes from NVIDIA#431 without changing their implementation. AMD hardware enablement should not change NVIDIA/Dynamo dependency installation.
Review concerns
This is deliberately draft: container/Python-environment isolation and shared-filesystem lock scope need independent review. It is not required merely because hardware is AMD, and the AgentX native-SGLang sweep does not validate Dynamo. No Dynamo E2E claim is made.
The AMD validation integration can retain this commit to preserve the previously combined implementation; merging the AMD base does not merge these installation changes.