Skip to content

feat(agentx): add concise agentx scenario defaults - #47

Merged
cquil11 merged 1 commit into
masterfrom
cquil11/agentx-scenario-defaults
Oct 1, 2026
Merged

cquil11 merged 1 commit into
masterfrom
cquil11/agentx-scenario-defaults

Conversation

@cquil11

@cquil11 cquil11 commented Oct 1, 2026 •

Copy link
Copy Markdown

Add --scenario agentx so InferenceX's repeated benchmark arguments and runtime settings become scenario defaults. Explicit settings still take precedence.

Before

From the InferenceX standalone command, with common variable and directory setup omitted:

export AIPERF_DATASET_WEKA_LIVE_ASSISTANT_RESPONSES=0
export AIPERF_DATASET_CONFIGURATION_TIMEOUT=1800
export AIPERF_SERVICE_PROFILE_CONFIGURE_TIMEOUT=1800
export AIPERF_UI_REALTIME_METRICS_ENABLED=true
export AIPERF_HTTP_TCP_USER_TIMEOUT=900000

aiperf profile \
  --scenario inferencex-agentx-mvp \
  --url "$SERVER_URL" --endpoint /v1/chat/completions \
  --endpoint-type chat --streaming \
  --model "$SERVED_MODEL_NAME" --tokenizer "$TOKENIZER" \
  --tokenizer-trust-remote-code \
  --concurrency "$CONC" --benchmark-duration 3600 \
  --stats-interval 30 --random-seed 42 \
  --failed-request-threshold 0.10 \
  --trajectory-start-min-ratio 0.25 --trajectory-start-max-ratio 0.75 \
  --warmup-requests-per-lane 10 --warmup-grace-period 1800 \
  --trace-idle-gap-cap-seconds 300 \
  --use-server-token-count --no-gpu-telemetry \
  --num-dataset-entries 393 --slice-duration 1.0 \
  --public-dataset "$DATASET" \
  --output-artifact-dir "$OUTPUT_DIR/aiperf_artifacts" \
  2>&1 | tee "$OUTPUT_DIR/aiperf.log"

After

aiperf profile \
  --scenario agentx \
  --url "$SERVER_URL" --endpoint /v1/chat/completions \
  --model "$SERVED_MODEL_NAME" --tokenizer "$TOKENIZER" \
  --tokenizer-trust-remote-code \
  --concurrency "$CONC" \
  --public-dataset "$DATASET" \
  --output-artifact-dir "$OUTPUT_DIR/aiperf_artifacts" \
  2>&1 | tee "$OUTPUT_DIR/aiperf.log"

The preset supplies the omitted arguments and four runtime settings. The old AIPERF_DATASET_WEKA_LIVE_ASSISTANT_RESPONSES export is unused and can also be dropped. Tokenizer trust remains explicit; the original MVP scenario retains its defaults.

Uses the shared scenario-defaults plumbing from ai-dynamo/aiperf#1495, now included in fork master. CLI presets apply to flag-based commands; --config keeps its YAML configuration path.

@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Try out this PR

Quick install:

pip install --upgrade --force-reinstall git+https://github.com/ai-dynamo/aiperf.git@6f666ba0ff5e8a09a2d44d4e162b236846b63dd9

Recommended with virtual environment (using uv):

uv venv --python 3.12 && source .venv/bin/activate
uv pip install --upgrade --force-reinstall git+https://github.com/ai-dynamo/aiperf.git@6f666ba0ff5e8a09a2d44d4e162b236846b63dd9

Last updated for commit: 6f666ba • Browse code

@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Fern Docs Preview: generation failed — see the Actions log for details. This does not block merge; ask a maintainer to retry if needed.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 129f195. Configure here.

Comment thread src/aiperf/common/scenario/environment.py Outdated
@cquil11
cquil11 force-pushed the cquil11/agentx-scenario-defaults branch from b0b29d5 to 082dfc7 Compare October 1, 2026 21:57
@cquil11
cquil11 changed the base branch from master to cquil11/scenario-defaults-base October 1, 2026 21:57
@cquil11
cquil11 force-pushed the cquil11/agentx-scenario-defaults branch from 082dfc7 to fd6e498 Compare October 1, 2026 22:06
@cquil11 cquil11 changed the title feat(agentx): add concise agentx scenario defaults feat(agentx): add scenario defaults Oct 1, 2026
@cquil11 cquil11 changed the title feat(agentx): add scenario defaults feat(agentx): add concise agentx scenario defaults Oct 1, 2026
@github-actions github-actions Bot added the feat label Oct 1, 2026
Signed-off-by: Cam Quilici <cjquilici@gmail.com>
@cquil11
cquil11 force-pushed the cquil11/agentx-scenario-defaults branch from fd6e498 to 6f666ba Compare October 1, 2026 22:11
@cquil11
cquil11 changed the base branch from cquil11/scenario-defaults-base to master October 1, 2026 22:11
@cquil11
cquil11 merged commit 89b2186 into master Oct 1, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant