Skip to content

[Klaud Cold] Update DSR1 FP8 MI355X ATOM MTP image to v0.1.7 / [Klaud Cold] 将 DSR1 FP8 MI355X ATOM MTP 镜像更新至 v0.1.7 #3915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Klaud-Cold wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −2
Open

[Klaud Cold] Update DSR1 FP8 MI355X ATOM MTP image to v0.1.7 / [Klaud Cold] 将 DSR1 FP8 MI355X ATOM MTP 镜像更新至 v0.1.7 #3915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb9f066
feat(amd): update DSR1 FP8 MI355X ATOM MTP image to v0.1.7
github-actions[bot] Oct 11, 2026
bdf5382
chore(changelog): record DSR1 FP8 MI355X ATOM MTP image update
github-actions[bot] Oct 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion inferencex-e2e/benchmarks/single_node/srt-slurm-recipes/dsr1/atom/mi355x-fp8-mtp/8k1k.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ base:
name: dsr1-fp8-mi355x-atom-mtp-8k1k
model:
path: hf:deepseek-ai/DeepSeek-R1-0528
container: rocm/atom:rocm7.2.4_ubuntu24.04_py3.12_pytorch_release_2.10.0_atom0.1.3
container: rocm/atom-dev:nightly_202610080328@sha256:9c3070bb7d2600d2e1bcfd03cf5f71e4dc0941f3e1d20d3a5845056aae2334eb
precision: fp8
resources:
gpu_type: mi355x
Expand Down
2 changes: 1 addition & 1 deletion inferencex-e2e/configs/amd-master.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,7 @@ dsr1-fp8-mi355x-atom:
srt-recipe: benchmarks/single_node/srt-slurm-recipes/dsr1/atom/mi355x-fp8/8k1k.yaml

dsr1-fp8-mi355x-atom-mtp:
image: rocm/atom:rocm7.2.4_ubuntu24.04_py3.12_pytorch_release_2.10.0_atom0.1.3
image: rocm/atom-dev:nightly_202610080328@sha256:9c3070bb7d2600d2e1bcfd03cf5f71e4dc0941f3e1d20d3a5845056aae2334eb
model: deepseek-ai/DeepSeek-R1-0528
model-prefix: dsr1
runner: mi355x
Expand Down
6 changes: 6 additions & 0 deletions inferencex-e2e/perf-changelog.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9538,3 +9538,9 @@
- "Run prefill context parallelism on the TP-only arms at conc 16, 32 and 48; conc 1 and 4 keep BCG."
- "Enable SGLANG_OPT_FP8_WO_A_FUSED_INVROPE."
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/3778

- config-keys:
- dsr1-fp8-mi355x-atom-mtp
description:
- "Update ATOM image from v0.1.3 to the v0.1.7 release build (rocm/atom-dev:nightly_202610080328, digest-pinned)."
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/3915

@claude claude Bot Oct 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 (optional) Changelog entry says image was updated "to the v0.1.7 release build" but the actual image pinned in both YAMLs is rocm/atom-dev:nightly_202610080328, a nightly dev build with no v0.1.7 tag anywhere. Anyone reading perf-changelog.yaml later to find which release is running will be misled into believing a tagged v0.1.7 release is deployed when it's actually an untagged nightly/dev digest build. Fix: make the description match the actual reference, e.g. "Update ATOM image from v0.1.3 to nightly build rocm/atom-dev:nightly_202610080328 (digest-pinned)", dropping the unverifiable "v0.1.7 release build" claim.

Why this was flagged

perf-changelog.yaml:9544 adds config-keys: [dsr1-fp8-mi355x-atom-mtp] with description:9546 "Update ATOM image from v0.1.3 to the v0.1.7 release build (rocm/atom-dev:nightly_202610080328, digest-pinned)". The actual image set at 8k1k.yaml:6 and amd-master.yaml:533 is rocm/atom-dev:nightly_202610080328@ sha256:9c3070bb..., which is a nightly/dev tag, not a release tag, and no v0.1.7 string appears anywhere in the diff. A later engineer or on-call reading the changelog to understand provenance of a regression will believe a stable v0.1.7 release is running and rule out nightly-build instability as a cause. No CI check cross-validates changelog description text against the image string, so nothing catches this mismatch before merge.

Verification: nit. The changelog entry at inferencex-e2e/perf-changelog.yaml:9545 reads "Update ATOM image from v0.1.3 to the v0.1.7 release build (rocm/atom-dev:nightly_202610080328, digest-pinned)." but the image actually pinned at inferencex-e2e/benchmarks/single_node/srt-slurm-recipes/dsr1/atom/mi355x-fp8-mtp/8k1k.yaml:6 and inferencex-e2e/configs/amd-master.yaml:535 is rocm/atom-dev:nightly_202610080328@ sha256:9c3070bb..., a nightly dev-channel build, not a "release build".

Loading